Commit 879de98e authored May 13, 2018 by Dave Chinner Committed by Darrick J. Wong May 15, 2018

xfs: one-shot cached buffers



For the new growfs work, we want to ensure that we serialise
secondary superblock updates with other operations (e.g. scrub)
correctly, but we don't want to cache the buffers for long term
reuse. We need cached buffers for serialisation, however.

To solve this, introduce a "oneshot" buffer which will be marshalled
through the cache but then released once the last current reference
goes away. If the buffer is already cached, then we ignore the
"one-shot" behaviour and leave the buffer in the state it was prior
to the one-shot command being run. This means we don't perturb
either the working set or existing cached buffer state by a one-shot
operation.

Signed-Off-By: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

parent 84d42ea6

fs/xfs/xfs_buf.h

+12 −0

Original line number	Diff line number	Diff line
		@@ -347,6 +347,18 @@ extern void xfs_buf_terminate(void);

		void xfs_buf_set_ref(struct xfs_buf *bp, int lru_ref);

		/*
		* If the buffer is already on the LRU, do nothing. Otherwise set the buffer
		* up with a reference count of 0 so it will be tossed from the cache when
		* released.
		*/
		static inline void xfs_buf_oneshot(struct xfs_buf *bp)
		{
		if (!list_empty(&bp->b_lru) \|\| atomic_read(&bp->b_lru_ref) > 1)
		return;
		atomic_set(&bp->b_lru_ref, 0);
		}

		static inline int xfs_buf_ispinned(struct xfs_buf *bp)
		{
		return atomic_read(&bp->b_pin_count);

Admin message