Commit 879d77d0 authored May 16, 2012 by Namhyung Kim Committed by Arnaldo Carvalho de Melo May 16, 2012

Revert 'perf evlist: Fix creation of cpu map'



The commit 55261f46 ("perf evlist: Fix creation of cpu map") changed
to create a per-task event when no cpu target is specified. However it
caused a problem since perf-task do not allow event inheritance due to
scalability issues so that the result will contain samples only from
parent, not from its children.

So we should use perf-task-per-cpu events anyway to get the right
result. Revert it.

Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Analysed-by: Ingo Molnar <mingo@kernel.org>
Acked-and-tested-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Namhyung Kim <namhyung.kim@lge.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1337161549-9870-2-git-send-email-namhyung.kim@lge.com


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent aa22dd49

tools/perf/util/evlist.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -609,10 +609,10 @@ int perf_evlist__create_maps(struct perf_evlist *evlist,
		if (evlist->threads == NULL)
		return -1;

		if (perf_target__has_cpu(target))
		evlist->cpus = cpu_map__new(target->cpu_list);
		else
		if (perf_target__has_task(target))
		evlist->cpus = cpu_map__dummy_new();
		else
		evlist->cpus = cpu_map__new(target->cpu_list);

		if (evlist->cpus == NULL)
		goto out_delete_threads;

Admin message