Commit 879be4f3 authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds
Browse files

checkpatch: reduce git commit description style false positives 

Some lines in a commit log appear to be commit SHA1 ids like:

  ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")'
  Link: http://lkml.kernel.org/r/40e03fd7aaf1f55c75d787128d6d17c5a71226c2.1464358556.git.vdavydov@virtuozzo.com

Reduce the false positives.

Link: http://lkml.kernel.org/r/eda977eaa8328fef42bb3c87935d97e10ea8ff67.1464384023.git.joe@perches.com


Signed-off-by: default avatarJoe Perches <joe@perches.com>
Reported-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 43afc194

scripts/checkpatch.pl

+1 −0
Original line number Diff line number Diff line
@@ -2454,6 +2454,7 @@ sub process { 


# Check for git id commit length and improperly formed commit descriptions

		if ($in_commit_log && !$commit_log_possible_stack_dump &&

		    $line !~ /^\s*(?:Link|Patchwork|http|BugLink):/i &&

		    ($line =~ /\bcommit\s+[0-9a-f]{5,}\b/i ||

		     ($line =~ /\b[0-9a-f]{12,40}\b/i &&

		      $line !~ /[\<\[][0-9a-f]{12,40}[\>\]]/i &&

CRA Git | Maintained and supported by SUSTech CRA and CCSE