net/ncsi: Silence debug messages (87975a01) · Commits · 戴 / test

In normal operation we see this series of messages as the host drives the network device: ftgmac100 1e660000.ethernet eth0: NCSI: LSC AEN - channel 0 state down ftgmac100 1e660000.ethernet eth0: NCSI: suspending channel 0 ftgmac100 1e660000.ethernet eth0: NCSI: configuring channel 0 ftgmac100 1e660000.ethernet eth0: NCSI: channel 0 link down after config ftgmac100 1e660000.ethernet eth0: NCSI interface down ftgmac100 1e660000.ethernet eth0: NCSI: LSC AEN - channel 0 state up ftgmac100 1e660000.ethernet eth0: NCSI: configuring channel 0 ftgmac100 1e660000.ethernet eth0: NCSI interface up ftgmac100 1e660000.ethernet eth0: NCSI: LSC AEN - channel 0 state down ftgmac100 1e660000.ethernet eth0: NCSI: suspending channel 0 ftgmac100 1e660000.ethernet eth0: NCSI: configuring channel 0 ftgmac100 1e660000.ethernet eth0: NCSI: channel 0 link down after config ftgmac100 1e660000.ethernet eth0: NCSI interface down ftgmac100 1e660000.ethernet eth0: NCSI: LSC AEN - channel 0 state up ftgmac100 1e660000.ethernet eth0: NCSI: configuring channel 0 ftgmac100 1e660000.ethernet eth0: NCSI interface up This makes all of these messages netdev_dbg. They are still useful to debug eg. misbehaving network device firmware, but we do not need them filling up the kernel logs in normal operation. Acked-by:

Samuel Mendoza-Jonas <sam@mendozajonas.com> Signed-off-by:

Joel Stanley <joel@jms.id.au> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/ethernet/faraday/ftgmac100.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1735,7 +1735,7 @@ static void ftgmac100_ncsi_handler(struct ncsi_dev *nd)
		if (unlikely(nd->state != ncsi_dev_state_functional))
		return;

		netdev_info(nd->dev, "NCSI interface %s\n",
		netdev_dbg(nd->dev, "NCSI interface %s\n",
		nd->link_up ? "up" : "down");
		}

net/ncsi/ncsi-aen.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -73,7 +73,7 @@ static int ncsi_aen_handler_lsc(struct ncsi_dev_priv *ndp,
		ncm->data[2] = data;
		ncm->data[4] = ntohl(lsc->oem_status);

		netdev_info(ndp->ndev.dev, "NCSI: LSC AEN - channel %u state %s\n",
		netdev_dbg(ndp->ndev.dev, "NCSI: LSC AEN - channel %u state %s\n",
		nc->id, data & 0x1 ? "up" : "down");

		chained = !list_empty(&nc->link);

net/ncsi/ncsi-manage.c

+7 −7

Original line number	Diff line number	Diff line
		@@ -816,7 +816,7 @@ static void ncsi_configure_channel(struct ncsi_dev_priv *ndp)
		} else {
		hot_nc = NULL;
		nc->state = NCSI_CHANNEL_INACTIVE;
		netdev_warn(ndp->ndev.dev,
		netdev_dbg(ndp->ndev.dev,
		"NCSI: channel %u link down after config\n",
		nc->id);
		}
		@@ -1199,13 +1199,13 @@ int ncsi_process_next_channel(struct ncsi_dev_priv *ndp)
		switch (old_state) {
		case NCSI_CHANNEL_INACTIVE:
		ndp->ndev.state = ncsi_dev_state_config;
		netdev_info(ndp->ndev.dev, "NCSI: configuring channel %u\n",
		netdev_dbg(ndp->ndev.dev, "NCSI: configuring channel %u\n",
		nc->id);
		ncsi_configure_channel(ndp);
		break;
		case NCSI_CHANNEL_ACTIVE:
		ndp->ndev.state = ncsi_dev_state_suspend;
		netdev_info(ndp->ndev.dev, "NCSI: suspending channel %u\n",
		netdev_dbg(ndp->ndev.dev, "NCSI: suspending channel %u\n",
		nc->id);
		ncsi_suspend_channel(ndp);
		break;

Admin message