Commit 8791a102 authored by Fabio Estevam's avatar Fabio Estevam Committed by Mauro Carvalho Chehab
Browse files

media: i2c: ov5640: Check for devm_gpiod_get_optional() error 



The power down and reset GPIO are optional, but the return value
from devm_gpiod_get_optional() needs to be checked and propagated
in the case of error, so that probe deferral can work.

Signed-off-by: default avatarFabio Estevam <festevam@gmail.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 4962bb38

drivers/media/i2c/ov5640.c

+5 −0
Original line number Diff line number Diff line
@@ -3022,9 +3022,14 @@ static int ov5640_probe(struct i2c_client *client, 
	/* request optional power down pin */

	sensor->pwdn_gpio = devm_gpiod_get_optional(dev, "powerdown",

						    GPIOD_OUT_HIGH);

	if (IS_ERR(sensor->pwdn_gpio))

		return PTR_ERR(sensor->pwdn_gpio);



	/* request optional reset pin */

	sensor->reset_gpio = devm_gpiod_get_optional(dev, "reset",

						     GPIOD_OUT_HIGH);

	if (IS_ERR(sensor->reset_gpio))

		return PTR_ERR(sensor->reset_gpio);



	v4l2_i2c_subdev_init(&sensor->sd, client, &ov5640_subdev_ops);

CRA Git | Maintained and supported by SUSTech CRA and CCSE