Commit 8786eda9 authored by Bjorn Helgaas's avatar Bjorn Helgaas Committed by Greg Kroah-Hartman
Browse files

misc: rtsx: Remove unused pcr_ops 



Remove the following unused function pointers from struct pcr_ops:

  int (*set_ltr_latency)(struct rtsx_pcr *pcr, u32 latency);
  int (*set_l1off_sub)(struct rtsx_pcr *pcr, u8 val);
  void (*full_on)(struct rtsx_pcr *pcr);
  void (*power_saving)(struct rtsx_pcr *pcr);

Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Link: https://lore.kernel.org/r/20200521180545.1159896-2-helgaas@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e18d4e9f

drivers/misc/cardreader/rtsx_pcr.c

+3 −12
Original line number Diff line number Diff line
@@ -85,9 +85,6 @@ static int rtsx_comm_set_ltr_latency(struct rtsx_pcr *pcr, u32 latency) 


int rtsx_set_ltr_latency(struct rtsx_pcr *pcr, u32 latency)

{

	if (pcr->ops->set_ltr_latency)

		return pcr->ops->set_ltr_latency(pcr, latency);

	else

	return rtsx_comm_set_ltr_latency(pcr, latency);

}
@@ -151,9 +148,6 @@ static void rtsx_comm_pm_full_on(struct rtsx_pcr *pcr) 


static void rtsx_pm_full_on(struct rtsx_pcr *pcr)

{

	if (pcr->ops->full_on)

		pcr->ops->full_on(pcr);

	else

	rtsx_comm_pm_full_on(pcr);

}
@@ -1108,9 +1102,6 @@ static void rtsx_comm_pm_power_saving(struct rtsx_pcr *pcr) 


static void rtsx_pm_power_saving(struct rtsx_pcr *pcr)

{

	if (pcr->ops->power_saving)

		pcr->ops->power_saving(pcr);

	else

	rtsx_comm_pm_power_saving(pcr);

}

include/linux/rtsx_pci.h

+0 −4
Original line number Diff line number Diff line
@@ -1080,11 +1080,7 @@ struct pcr_ops { 
	void		(*stop_cmd)(struct rtsx_pcr *pcr);



	void (*set_aspm)(struct rtsx_pcr *pcr, bool enable);

	int (*set_ltr_latency)(struct rtsx_pcr *pcr, u32 latency);

	int (*set_l1off_sub)(struct rtsx_pcr *pcr, u8 val);

	void (*set_l1off_cfg_sub_d0)(struct rtsx_pcr *pcr, int active);

	void (*full_on)(struct rtsx_pcr *pcr);

	void (*power_saving)(struct rtsx_pcr *pcr);

	void (*enable_ocp)(struct rtsx_pcr *pcr);

	void (*disable_ocp)(struct rtsx_pcr *pcr);

	void (*init_ocp)(struct rtsx_pcr *pcr);

CRA Git | Maintained and supported by SUSTech CRA and CCSE