Commit 8778eb09 authored Jul 06, 2020 by Zhang Qiang Committed by Felipe Balbi Jul 09, 2020

usb: gadget: function: fix missing spinlock in f_uac1_legacy



Add a missing spinlock protection for play_queue, because
the play_queue may be destroyed when the "playback_work"
work func and "f_audio_out_ep_complete" callback func
operate this paly_queue at the same time.

Fixes: c6994e6f ("USB: gadget: add USB Audio Gadget driver")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Zhang Qiang <qiang.zhang@windriver.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>

parent 30517ffe

drivers/usb/gadget/function/f_uac1_legacy.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -336,7 +336,9 @@ static int f_audio_out_ep_complete(struct usb_ep ep, struct usb_request req)

		/* Copy buffer is full, add it to the play_queue */
		if (audio_buf_size - copy_buf->actual < req->actual) {
		spin_lock_irq(&audio->lock);
		list_add_tail(&copy_buf->list, &audio->play_queue);
		spin_unlock_irq(&audio->lock);
		schedule_work(&audio->playback_work);
		copy_buf = f_audio_buffer_alloc(audio_buf_size);
		if (IS_ERR(copy_buf))

Admin message