Commit 876e956f authored Mar 09, 2010 by Julia Lawall Committed by David S. Miller Mar 15, 2010

drivers/net: drop redundant memset

The region set by the call to memset is immediately overwritten by the
subsequent call to memcpy.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression e1,e2,e3,e4;
@@

- memset(e1,e2,e3);
  memcpy(e1,e4,e3);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 255f5c32

drivers/net/s2io.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -5819,10 +5819,8 @@ static void s2io_vpd_read(struct s2io_nic *nic)
		}
		}

		if ((!fail) && (vpd_data[1] < VPD_STRING_LEN)) {
		memset(nic->product_name, 0, vpd_data[1]);
		if ((!fail) && (vpd_data[1] < VPD_STRING_LEN))
		memcpy(nic->product_name, &vpd_data[3], vpd_data[1]);
		}
		kfree(vpd_data);
		swstats->mem_freed += 256;
		}

Admin message