Commit 875aac8a authored Jan 07, 2019 by Shunyong Yang Committed by Vinod Koul Jan 20, 2019

dmaengine: qcom_hidma: initialize tx flags in hidma_prep_dma_*



In async_tx_test_ack(), it uses flags in struct dma_async_tx_descriptor
to check the ACK status. As hidma reuses the descriptor in a free list
when hidma_prep_dma_*(memcpy/memset) is called, the flag will keep ACKed
if the descriptor has been used before. This will cause a BUG_ON in
async_tx_quiesce().

  kernel BUG at crypto/async_tx/async_tx.c:282!
  Internal error: Oops - BUG: 0 1 SMP
  ...
  task: ffff8017dd3ec000 task.stack: ffff8017dd3e8000
  PC is at async_tx_quiesce+0x54/0x78 [async_tx]
  LR is at async_trigger_callback+0x98/0x110 [async_tx]

This patch initializes flags in dma_async_tx_descriptor by the flags
passed from the caller when hidma_prep_dma_*(memcpy/memset) is called.

Cc: Joey Zheng <yu.zheng@hxt-semitech.com>
Reviewed-by: Sinan Kaya <okaya@kernel.org>
Signed-off-by: Shunyong Yang <shunyong.yang@hxt-semitech.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent edd3c389

drivers/dma/qcom/hidma.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -415,6 +415,7 @@ hidma_prep_dma_memcpy(struct dma_chan *dmach, dma_addr_t dest, dma_addr_t src,
		if (!mdesc)
		return NULL;

		mdesc->desc.flags = flags;
		hidma_ll_set_transfer_params(mdma->lldev, mdesc->tre_ch,
		src, dest, len, flags,
		HIDMA_TRE_MEMCPY);
		@@ -447,6 +448,7 @@ hidma_prep_dma_memset(struct dma_chan *dmach, dma_addr_t dest, int value,
		if (!mdesc)
		return NULL;

		mdesc->desc.flags = flags;
		hidma_ll_set_transfer_params(mdma->lldev, mdesc->tre_ch,
		value, dest, len, flags,
		HIDMA_TRE_MEMSET);

Admin message