Commit 8759f904 authored May 12, 2014 by Jean Delvare Committed by Guenter Roeck May 12, 2014

hwmon: (emc1403) Fix resource leak on module unload



Commit 454aee17 claims to convert driver emc1403 to use
devm_hwmon_device_register_with_groups, however the patch itself makes
use of hwmon_device_register_with_groups instead. As the driver remove
function was still dropped, the hwmon device is no longer unregistered
on driver removal, leading to a resource leak.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Fixes: 454aee17 hwmon: (emc1403) Convert to use devm_hwmon_device_register_with_groups
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: stable@vger.kernel.org [3.13+]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent 17c048fc

drivers/hwmon/emc1403.c

+3 −3

Original line number	Original line	Diff line number	Diff line
	@@ -355,7 +355,7 @@ static int emc1403_probe(struct i2c_client *client,
	if (id->driver_data)		if (id->driver_data)
	data->groups[1] = &emc1404_group;		data->groups[1] = &emc1404_group;

	hwmon_dev = hwmon_device_register_with_groups(&client->dev,		hwmon_dev = devm_hwmon_device_register_with_groups(&client->dev,
	client->name, data,		client->name, data,
	data->groups);		data->groups);
	if (IS_ERR(hwmon_dev))		if (IS_ERR(hwmon_dev))

Admin message