Commit 874fb9e2 authored Oct 09, 2020 by David Ahern Committed by Jakub Kicinski Oct 10, 2020

ipv4: Restore flowi4_oif update before call to xfrm_lookup_route



Tobias reported regressions in IPsec tests following the patch
referenced by the Fixes tag below. The root cause is dropping the
reset of the flowi4_oif after the fib_lookup. Apparently it is
needed for xfrm cases, so restore the oif update to ip_route_output_flow
right before the call to xfrm_lookup_route.

Fixes: 2fbc6e89 ("ipv4: Update exception handling for multipath routes via same device")
Reported-by: Tobias Brunner <tobias@strongswan.org>
Signed-off-by: David Ahern <dsahern@kernel.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent 49fb2f33

net/ipv4/route.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -2769,10 +2769,12 @@ struct rtable ip_route_output_flow(struct net net, struct flowi4 *flp4,
		if (IS_ERR(rt))
		return rt;

		if (flp4->flowi4_proto)
		if (flp4->flowi4_proto) {
		flp4->flowi4_oif = rt->dst.dev->ifindex;
		rt = (struct rtable *)xfrm_lookup_route(net, &rt->dst,
		flowi4_to_flowi(flp4),
		sk, 0);
		}

		return rt;
		}

Admin message