Commit 874deb1c authored Sep 20, 2018 by Nathan Chancellor Committed by Martin K. Petersen Sep 20, 2018

scsi: advansys: Remove unnecessary parentheses

Clang warns when multiple pairs of parentheses are used for a single
conditional statement.

drivers/scsi/advansys.c:6451:20: warning: equality comparison with
extraneous parentheses [-Wparentheses-equality]
                                if ((sdtr_data == 0xFF)) {
                                     ~~~~~~~~~~^~~~~~~
drivers/scsi/advansys.c:6451:20: note: remove extraneous parentheses
around the comparison to silence this warning
                                if ((sdtr_data == 0xFF)) {
                                    ~          ^      ~
drivers/scsi/advansys.c:6451:20: note: use '=' to turn this equality
comparison into an assignment
                                if ((sdtr_data == 0xFF)) {
                                               ^~
                                               =
1 warning generated.

Link: https://github.com/ClangBuiltLinux/linux/issues/155


Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent fed564f6

drivers/scsi/advansys.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -6448,7 +6448,7 @@ static void AscIsrChipHalted(ASC_DVC_VAR *asc_dvc)
		sdtr_data =
		AscCalSDTRData(asc_dvc, ext_msg.xfer_period,
		ext_msg.req_ack_offset);
		if ((sdtr_data == 0xFF)) {
		if (sdtr_data == 0xFF) {

		q_cntl \|= QC_MSG_OUT;
		asc_dvc->init_sdtr &= ~target_id;

Admin message