Commit 871ef3b5 authored Jul 18, 2015 by Viresh Kumar Committed by Rafael J. Wysocki Jul 21, 2015

cpufreq: governor: Don't WARN on invalid states



With previous commit, governors have started to return errors on invalid
state-transition requests. We already have a WARN for an invalid
state-transition request in cpufreq_governor_dbs(). This does trigger
today, as the sequence of events isn't guaranteed by cpufreq core.

Lets stop warning on that for now, and make sure we don't enter an
invalid state.

Reviewed-and-tested-by: Preeti U Murthy <preeti@linux.vnet.ibm.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent a72c4959

drivers/cpufreq/cpufreq_governor.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -543,7 +543,7 @@ int cpufreq_governor_dbs(struct cpufreq_policy *policy,
		else
		dbs_data = cdata->gdbs_data;

		if (WARN_ON(!dbs_data && (event != CPUFREQ_GOV_POLICY_INIT))) {
		if (!dbs_data && (event != CPUFREQ_GOV_POLICY_INIT)) {
		ret = -EINVAL;
		goto unlock;
		}

Admin message