Commit 87154ff8 authored by Joe Perches's avatar Joe Perches Committed by Sam Ravnborg
Browse files

drm: Remove unnecessary drm_panel_attach and drm_panel_detach 



These functions are now empty and no longer
useful so remove the functions and their uses.

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Cc: Bernard Zhao <bernard@vivo.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>,
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Icenowy Zheng <icenowy@aosc.io>,
Cc: Jagan Teki <jagan@amarulasolutions.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Robert Chiras <robert.chiras@nxp.com>
Cc: dri-devel@lists.freedesktop.org,
Cc: linux-kernel@vger.kernel.org
Cc: opensource.kernel@vivo.com
Signed-off-by: Sam Ravnborg <sam@ravnborg.org> # Fixed build and a few warnings
Link: https://patchwork.freedesktop.org/patch/msgid/9e13761020750b1ce2f1fabee23ef6e2a2942882.camel@perches.com
parent 018315d3

drivers/gpu/drm/bridge/analogix/analogix-anx6345.c

+0 −12
Original line number Diff line number Diff line
@@ -507,10 +507,6 @@ static const struct drm_connector_helper_funcs anx6345_connector_helper_funcs = 
static void

anx6345_connector_destroy(struct drm_connector *connector)

{

	struct anx6345 *anx6345 = connector_to_anx6345(connector);



	if (anx6345->panel)

		drm_panel_detach(anx6345->panel);

	drm_connector_cleanup(connector);

}
@@ -575,14 +571,6 @@ static int anx6345_bridge_attach(struct drm_bridge *bridge, 
		return err;

	}



	if (anx6345->panel) {

		err = drm_panel_attach(anx6345->panel, &anx6345->connector);

		if (err) {

			DRM_ERROR("Failed to attach panel: %d\n", err);

			return err;

		}

	}



	return 0;

}

drivers/gpu/drm/bridge/analogix/analogix_dp_core.c

+0 −9
Original line number Diff line number Diff line
@@ -1265,14 +1265,6 @@ static int analogix_dp_bridge_attach(struct drm_bridge *bridge, 
		}

	}



	if (dp->plat_data->panel) {

		ret = drm_panel_attach(dp->plat_data->panel, &dp->connector);

		if (ret) {

			DRM_ERROR("Failed to attach panel\n");

			return ret;

		}

	}



	return 0;

}
@@ -1803,7 +1795,6 @@ void analogix_dp_unbind(struct analogix_dp_device *dp) 
	if (dp->plat_data->panel) {

		if (drm_panel_unprepare(dp->plat_data->panel))

			DRM_ERROR("failed to turnoff the panel\n");

		drm_panel_detach(dp->plat_data->panel);

	}



	drm_dp_aux_unregister(&dp->aux);

drivers/gpu/drm/bridge/panel.c

+0 −7
Original line number Diff line number Diff line
@@ -82,18 +82,11 @@ static int panel_bridge_attach(struct drm_bridge *bridge, 
	drm_connector_attach_encoder(&panel_bridge->connector,

					  bridge->encoder);



	ret = drm_panel_attach(panel_bridge->panel, &panel_bridge->connector);

	if (ret < 0)

		return ret;



	return 0;

}



static void panel_bridge_detach(struct drm_bridge *bridge)

{

	struct panel_bridge *panel_bridge = drm_bridge_to_panel_bridge(bridge);



	drm_panel_detach(panel_bridge->panel);

}



static void panel_bridge_pre_enable(struct drm_bridge *bridge)

drivers/gpu/drm/bridge/ti-sn65dsi86.c

+0 −3
Original line number Diff line number Diff line
@@ -394,9 +394,6 @@ static int ti_sn_bridge_attach(struct drm_bridge *bridge, 
	}

	pdata->dsi = dsi;



	/* attach panel to bridge */

	drm_panel_attach(pdata->panel, &pdata->connector);



	return 0;



err_dsi_attach:

drivers/gpu/drm/drm_panel.c

+0 −36
Original line number Diff line number Diff line
@@ -93,42 +93,6 @@ void drm_panel_remove(struct drm_panel *panel) 
}

EXPORT_SYMBOL(drm_panel_remove);



/**

 * drm_panel_attach - attach a panel to a connector

 * @panel: DRM panel

 * @connector: DRM connector

 *

 * After obtaining a pointer to a DRM panel a display driver calls this

 * function to attach a panel to a connector.

 *

 * An error is returned if the panel is already attached to another connector.

 *

 * When unloading, the driver should detach from the panel by calling

 * drm_panel_detach().

 *

 * Return: 0 on success or a negative error code on failure.

 */

int drm_panel_attach(struct drm_panel *panel, struct drm_connector *connector)

{

	return 0;

}

EXPORT_SYMBOL(drm_panel_attach);



/**

 * drm_panel_detach - detach a panel from a connector

 * @panel: DRM panel

 *

 * Detaches a panel from the connector it is attached to. If a panel is not

 * attached to any connector this is effectively a no-op.

 *

 * This function should not be called by the panel device itself. It

 * is only for the drm device that called drm_panel_attach().

 */

void drm_panel_detach(struct drm_panel *panel)

{

}

EXPORT_SYMBOL(drm_panel_detach);



/**

 * drm_panel_prepare - power on a panel

 * @panel: DRM panel

CRA Git | Maintained and supported by SUSTech CRA and CCSE