Commit 8711071e authored Oct 30, 2020 by Zhang Qilong Committed by Wim Van Sebroeck Dec 13, 2020

watchdog: rti-wdt: fix reference leak in rti_wdt_probe



pm_runtime_get_sync() will increment pm usage counter even it
failed. Forgetting to call pm_runtime_put_noidle will result
in reference leak in rti_wdt_probe, so we should fix it.

Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20201030154909.100023-1-zhangqilong3@huawei.com


Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>

parent 8650d0f9

drivers/watchdog/rti_wdt.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -227,8 +227,10 @@ static int rti_wdt_probe(struct platform_device *pdev)

		pm_runtime_enable(dev);
		ret = pm_runtime_get_sync(dev);
		if (ret)
		if (ret) {
		pm_runtime_put_noidle(dev);
		return dev_err_probe(dev, ret, "runtime pm failed\n");
		}

		platform_set_drvdata(pdev, wdt);

Admin message