net: sctp: fix warning "NULL check before some freeing functions is not needed" (86fda90a) · Commits · 戴 / test

This patch removes NULL checks before calling kfree. fixes below issues reported by coccicheck net/sctp/sm_make_chunk.c:2586:3-8: WARNING: NULL check before some freeing functions is not needed. net/sctp/sm_make_chunk.c:2652:3-8: WARNING: NULL check before some freeing functions is not needed. net/sctp/sm_make_chunk.c:2667:3-8: WARNING: NULL check before some freeing functions is not needed. net/sctp/sm_make_chunk.c:2684:3-8: WARNING: NULL check before some freeing functions is not needed. Signed-off-by:

Hariprasad Kelam <hariprasad.kelam@gmail.com> Acked-by:

Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> Acked-by:

Neil Horman <nhorman@tuxdriver.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

net/sctp/sm_make_chunk.c

+4 −8

Original line number	Diff line number	Diff line
		@@ -2582,7 +2582,6 @@ do_addr_param:
		case SCTP_PARAM_STATE_COOKIE:
		asoc->peer.cookie_len =
		ntohs(param.p->length) - sizeof(struct sctp_paramhdr);
		if (asoc->peer.cookie)
		kfree(asoc->peer.cookie);
		asoc->peer.cookie = kmemdup(param.cookie->body, asoc->peer.cookie_len, gfp);
		if (!asoc->peer.cookie)
		@@ -2648,7 +2647,6 @@ do_addr_param:
		goto fall_through;

		/* Save peer's random parameter */
		if (asoc->peer.peer_random)
		kfree(asoc->peer.peer_random);
		asoc->peer.peer_random = kmemdup(param.p,
		ntohs(param.p->length), gfp);
		@@ -2663,7 +2661,6 @@ do_addr_param:
		goto fall_through;

		/* Save peer's HMAC list */
		if (asoc->peer.peer_hmacs)
		kfree(asoc->peer.peer_hmacs);
		asoc->peer.peer_hmacs = kmemdup(param.p,
		ntohs(param.p->length), gfp);
		@@ -2680,7 +2677,6 @@ do_addr_param:
		if (!ep->auth_enable)
		goto fall_through;

		if (asoc->peer.peer_chunks)
		kfree(asoc->peer.peer_chunks);
		asoc->peer.peer_chunks = kmemdup(param.p,
		ntohs(param.p->length), gfp);

Admin message