Unverified Commit 86f56395 authored by Christian Brauner's avatar Christian Brauner
Browse files

tests: test for setns() EINVAL regression 

Verify that setns() reports EINVAL when an fd is passed that refers to an
open file but the file is not a file descriptor useable to interact with
namespaces.

Cc: Jan Stancek <jstancek@redhat.com>
Cc: Cyril Hrubis <chrubis@suse.cz>
Link: https://lore.kernel.org/lkml/20200615085836.GR12456@shao2-debian


Signed-off-by: default avatarChristian Brauner <christian.brauner@ubuntu.com>
parent e571d4ee

tools/testing/selftests/pidfd/pidfd.h

+5 −0
Original line number Diff line number Diff line
@@ -95,4 +95,9 @@ static inline int sys_pidfd_getfd(int pidfd, int fd, int flags) 
	return syscall(__NR_pidfd_getfd, pidfd, fd, flags);

}



static inline int sys_memfd_create(const char *name, unsigned int flags)

{

	return syscall(__NR_memfd_create, name, flags);

}



#endif /* __PIDFD_H */

tools/testing/selftests/pidfd/pidfd_getfd_test.c

+0 −5
Original line number Diff line number Diff line
@@ -34,11 +34,6 @@ static int sys_kcmp(pid_t pid1, pid_t pid2, int type, unsigned long idx1, 
	return syscall(__NR_kcmp, pid1, pid2, type, idx1, idx2);

}



static int sys_memfd_create(const char *name, unsigned int flags)

{

	return syscall(__NR_memfd_create, name, flags);

}



static int __child(int sk, int memfd)

{

	int ret;

tools/testing/selftests/pidfd/pidfd_setns_test.c

+12 −0
Original line number Diff line number Diff line
@@ -470,4 +470,16 @@ TEST_F(current_nsset, no_foul_play) 
	}

}



TEST(setns_einval)

{

	int fd;



	fd = sys_memfd_create("rostock", 0);

	EXPECT_GT(fd, 0);



	ASSERT_NE(setns(fd, 0), 0);

	EXPECT_EQ(errno, EINVAL);

	close(fd);

}



TEST_HARNESS_MAIN

CRA Git | Maintained and supported by SUSTech CRA and CCSE