Commit 86f3f4cd authored Jan 14, 2020 by Johan Hovold Committed by David S. Miller Jan 14, 2020

r8152: add missing endpoint sanity check



Add missing endpoint sanity check to probe in order to prevent a
NULL-pointer dereference (or slab out-of-bounds access) when retrieving
the interrupt-endpoint bInterval on ndo_open() in case a device lacks
the expected endpoints.

Fixes: 40a82917 ("net/usb/r8152: enable interrupt transfer")
Cc: hayeswang <hayeswang@realtek.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent c742c59e

drivers/net/usb/r8152.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -6597,6 +6597,9 @@ static int rtl8152_probe(struct usb_interface *intf,
		return -ENODEV;
		}

		if (intf->cur_altsetting->desc.bNumEndpoints < 3)
		return -ENODEV;

		usb_reset_device(udev);
		netdev = alloc_etherdev(sizeof(struct r8152));
		if (!netdev) {

Admin message