Commit 86de7ced authored by Alex Maftei (amaftei)'s avatar Alex Maftei (amaftei) Committed by David S. Miller
Browse files

sfc: refactor selftest work init code 



Signed-off-by: default avatarAlexandru-Mihai Maftei <amaftei@solarflare.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9f120e76

drivers/net/ethernet/sfc/efx_common.c

+1 −1
Original line number Diff line number Diff line
@@ -840,7 +840,7 @@ int efx_init_struct(struct efx_nic *efx, 
#endif

	INIT_WORK(&efx->reset_work, efx_reset_work);

	INIT_DELAYED_WORK(&efx->monitor_work, efx_monitor);

	INIT_DELAYED_WORK(&efx->selftest_work, efx_selftest_async_work);

	efx_selftest_async_init(efx);

	efx->pci_dev = pci_dev;

	efx->msg_enable = debug;

	efx->state = STATE_UNINIT;

drivers/net/ethernet/sfc/selftest.c

+6 −1
Original line number Diff line number Diff line
@@ -785,7 +785,7 @@ void efx_selftest_async_cancel(struct efx_nic *efx) 
	cancel_delayed_work_sync(&efx->selftest_work);

}



void efx_selftest_async_work(struct work_struct *data)

static void efx_selftest_async_work(struct work_struct *data)

{

	struct efx_nic *efx = container_of(data, struct efx_nic,

					   selftest_work.work);
@@ -804,3 +804,8 @@ void efx_selftest_async_work(struct work_struct *data) 
				  channel->channel, cpu);

	}

}



void efx_selftest_async_init(struct efx_nic *efx)

{

	INIT_DELAYED_WORK(&efx->selftest_work, efx_selftest_async_work);

}

drivers/net/ethernet/sfc/selftest.h

+1 −1
Original line number Diff line number Diff line
@@ -45,8 +45,8 @@ void efx_loopback_rx_packet(struct efx_nic *efx, const char *buf_ptr, 
			    int pkt_len);

int efx_selftest(struct efx_nic *efx, struct efx_self_tests *tests,

		 unsigned flags);

void efx_selftest_async_init(struct efx_nic *efx);

void efx_selftest_async_start(struct efx_nic *efx);

void efx_selftest_async_cancel(struct efx_nic *efx);

void efx_selftest_async_work(struct work_struct *data);



#endif /* EFX_SELFTEST_H */

CRA Git | Maintained and supported by SUSTech CRA and CCSE