Commit 86d5e657 authored Dec 22, 2015 by Linus Walleij Committed by Olof Johansson Dec 22, 2015

ARM: scoop: Be sure to clamp return value

As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Cc: arm@kernel.org
Cc: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Olof Johansson <olof@lixom.net>

parent 4749edf8

arch/arm/common/scoop.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -84,7 +84,7 @@ static int scoop_gpio_get(struct gpio_chip *chip, unsigned offset)
		struct scoop_dev *sdev = container_of(chip, struct scoop_dev, gpio);

		/* XXX: I'm unsure, but it seems so */
		return ioread16(sdev->base + SCOOP_GPRR) & (1 << (offset + 1));
		return !!(ioread16(sdev->base + SCOOP_GPRR) & (1 << (offset + 1)));
		}

		static int scoop_gpio_direction_input(struct gpio_chip *chip,

Admin message