Commit 86d4d78c authored Jun 13, 2013 by Rajendra Nayak Committed by Tony Lindgren Jun 18, 2013

ARM: OMAP: dma: Remove the erroneous freeing of platform data



Given p = pdev->dev.platform_data; and
      d = p->dma_attr;
the freeing of either one of these by the driver
seems just plain wrong.

Get rid of them in the .probe failure path as well as the
.remove.

Signed-off-by: Rajendra Nayak <rnayak@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>

parent f0a3ff27

arch/arm/plat-omap/dma.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -2111,8 +2111,6 @@ exit_dma_irq_fail:
		}

		exit_dma_lch_fail:
		kfree(p);
		kfree(d);
		kfree(dma_chan);
		return ret;
		}
		@@ -2133,8 +2131,6 @@ static int omap_system_dma_remove(struct platform_device *pdev)
		free_irq(dma_irq, (void *)(irq_rel + 1));
		}
		}
		kfree(p);
		kfree(d);
		kfree(dma_chan);
		return 0;
		}

Admin message