Commit 86c31524 authored Nov 14, 2018 by Kai-Heng Feng Committed by Jiri Kosina Nov 19, 2018

HID: i2c-hid: Disable runtime PM for LG touchscreen



LG touchscreen (1fd2:8001) stops working after reboot:
[ 4.859153] i2c_hid i2c-SAPS2101:00: i2c_hid_get_input: incomplete report (64/66)
[ 4.936070] i2c_hid i2c-SAPS2101:00: i2c_hid_get_input: incomplete report (64/66)
[ 9.948224] i2c_hid i2c-SAPS2101:00: failed to reset device.

The device in question stops working after receives SLEEP, ON, SLEEP
commands in a short period. The scenario is like this:
- Once the desktop session closes, it also closed the hid device, so the
device gets runtime suspended and receives a SLEEP command.
- Before calling shutdown callback, it gets runtime resumed and received
an ON command.
- In the shutdown callback, it receives another SLEEP command.

I failed to find a reliable interval between ON/SLEEP commands that can
make it work, so let's simply disable runtime PM for the device.

Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent 12d43aac

drivers/hid/hid-ids.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -710,6 +710,7 @@
		#define USB_VENDOR_ID_LG 0x1fd2
		#define USB_DEVICE_ID_LG_MULTITOUCH 0x0064
		#define USB_DEVICE_ID_LG_MELFAS_MT 0x6007
		#define I2C_DEVICE_ID_LG_8001 0x8001

		#define USB_VENDOR_ID_LOGITECH 0x046d
		#define USB_DEVICE_ID_LOGITECH_AUDIOHUB 0x0a0e

drivers/hid/i2c-hid/i2c-hid-core.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -177,6 +177,8 @@ static const struct i2c_hid_quirks {
		I2C_HID_QUIRK_NO_RUNTIME_PM },
		{ I2C_VENDOR_ID_RAYDIUM, I2C_PRODUCT_ID_RAYDIUM_4B33,
		I2C_HID_QUIRK_DELAY_AFTER_SLEEP },
		{ USB_VENDOR_ID_LG, I2C_DEVICE_ID_LG_8001,
		I2C_HID_QUIRK_NO_RUNTIME_PM },
		{ 0, 0 }
		};

Admin message