Commit 86b9c6f3 authored Dec 10, 2014 by Goldwyn Rodrigues Committed by Linus Torvalds Dec 10, 2014

ocfs2: remove filesize checks for sync I/O journal commit



Filesize is not a good indication that the file needs to be synced.
An example where this breaks is:
 1. Open the file in O_SYNC|O_RDWR
 2. Read a small portion of the file (say 64 bytes)
 3. Lseek to starting of the file
 4. Write 64 bytes

If the node crashes, it is not written out to disk because this was not
committed in the journal and the other node which reads the file after
recovery reads stale data (even if the write on the other node was
successful)

Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.de>
Reviewed-by: Mark Fasheh <mfasheh@suse.de>
Cc: Joel Becker <jlbec@evilplan.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 196fe71d

fs/ocfs2/file.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -2381,9 +2381,7 @@ out_dio:
		if (ret < 0)
		written = ret;

		if (!ret && ((old_size != i_size_read(inode)) \|\|
		(old_clusters != OCFS2_I(inode)->ip_clusters) \|\|
		has_refcount)) {
		if (!ret) {
		ret = jbd2_journal_force_commit(osb->journal->j_journal);
		if (ret < 0)
		written = ret;

Admin message