Commit 86b62e5c authored by Hans de Goede's avatar Hans de Goede Committed by Rafael J. Wysocki
Browse files

ACPI / LPSS: Exclude I2C busses shared with PUNIT from pmc_atom_d3_mask 



lpss_iosf_enter_d3_state() checks if all hw-blocks using the DMA
controllers are in d3 before powering down the DMA controllers.

But on devices, where the I2C bus connected to the PMIC is shared by
the PUNIT, the controller for that bus will never reach d3 since it has
an effectively empty _PS3 method. Instead it appears to automatically
power-down during S0i3 and we never see it as being in d3.

This causes the DMA controllers to never be powered-down on these devices,
causing them to never reach S0i3. This commit uses the ACPI _SEM method
to detect if an I2C bus is shared with the PUNIT and if it is, it removes
it from the mask of devices which lpss_iosf_enter_d3_state() checks for.

This fixes these devices never reaching any S0ix states.

Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Acked-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 24071406

drivers/acpi/acpi_lpss.c

+20 −2
Original line number Diff line number Diff line
@@ -99,6 +99,9 @@ struct lpss_private_data { 
	u32 prv_reg_ctx[LPSS_PRV_REG_COUNT];

};



/* Devices which need to be in D3 before lpss_iosf_enter_d3_state() proceeds */

static u32 pmc_atom_d3_mask = 0xfe000ffe;



/* LPSS run time quirks */

static unsigned int lpss_quirks;
@@ -175,6 +178,21 @@ static void byt_pwm_setup(struct lpss_private_data *pdata) 


static void byt_i2c_setup(struct lpss_private_data *pdata)

{

	const char *uid_str = acpi_device_uid(pdata->adev);

	acpi_handle handle = pdata->adev->handle;

	unsigned long long shared_host = 0;

	acpi_status status;

	long uid = 0;



	/* Expected to always be true, but better safe then sorry */

	if (uid_str)

		uid = simple_strtol(uid_str, NULL, 10);



	/* Detect I2C bus shared with PUNIT and ignore its d3 status */

	status = acpi_evaluate_integer(handle, "_SEM", NULL, &shared_host);

	if (ACPI_SUCCESS(status) && shared_host && uid)

		pmc_atom_d3_mask &= ~(BIT_LPSS2_F1_I2C1 << (uid - 1));



	lpss_deassert_reset(pdata);



	if (readl(pdata->mmio_base + pdata->dev_desc->prv_offset))
@@ -894,7 +912,7 @@ static void lpss_iosf_enter_d3_state(void) 
	 * Here we read the values related to LPSS power island, i.e. LPSS

	 * devices, excluding both LPSS DMA controllers, along with SCC domain.

	 */

	u32 func_dis, d3_sts_0, pmc_status, pmc_mask = 0xfe000ffe;

	u32 func_dis, d3_sts_0, pmc_status;

	int ret;



	ret = pmc_atom_read(PMC_FUNC_DIS, &func_dis);
@@ -912,7 +930,7 @@ static void lpss_iosf_enter_d3_state(void) 
	 * Shutdown both LPSS DMA controllers if and only if all other devices

	 * are already in D3hot.

	 */

	pmc_status = (~(d3_sts_0 | func_dis)) & pmc_mask;

	pmc_status = (~(d3_sts_0 | func_dis)) & pmc_atom_d3_mask;

	if (pmc_status)

		goto exit;

CRA Git | Maintained and supported by SUSTech CRA and CCSE