Commit 8673e944 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Enric Balletbo i Serra
Browse files

platform/chrome: wilco_ec: Platform data shouldn't include kernel.h



Replace with appropriate types.h.

Also there is no need to include device.h, but mutex.h.
For the pointers to unknown structures use forward declarations.

In the *.c files we need to include all headers that provide APIs
being used in the module.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarEnric Balletbo i Serra <enric.balletbo@collabora.com>
parent 2b63eb96
Loading
Loading
Loading
Loading
+3 −0
Original line number Diff line number Diff line
@@ -3,8 +3,11 @@
 * Copyright 2019 Google LLC
 */

#include <linux/errno.h>
#include <linux/export.h>
#include <linux/platform_data/wilco-ec.h>
#include <linux/string.h>
#include <linux/types.h>
#include <asm/unaligned.h>

/* Operation code; what the EC should do with the property */
+4 −0
Original line number Diff line number Diff line
@@ -8,8 +8,12 @@
 * See Documentation/ABI/testing/sysfs-platform-wilco-ec for more information.
 */

#include <linux/device.h>
#include <linux/kernel.h>
#include <linux/platform_data/wilco-ec.h>
#include <linux/string.h>
#include <linux/sysfs.h>
#include <linux/types.h>

#define CMD_KB_CMOS			0x7C
#define SUB_CMD_KB_CMOS_AUTO_ON		0x03
+6 −2
Original line number Diff line number Diff line
@@ -8,8 +8,8 @@
#ifndef WILCO_EC_H
#define WILCO_EC_H

#include <linux/device.h>
#include <linux/kernel.h>
#include <linux/mutex.h>
#include <linux/types.h>

/* Message flags for using the mailbox() interface */
#define WILCO_EC_FLAG_NO_RESPONSE	BIT(0) /* EC does not respond */
@@ -17,6 +17,10 @@
/* Normal commands have a maximum 32 bytes of data */
#define EC_MAILBOX_DATA_SIZE		32

struct device;
struct resource;
struct platform_device;

/**
 * struct wilco_ec_device - Wilco Embedded Controller handle.
 * @dev: Device handle.