Commit 866f3576 authored Aug 13, 2018 by Sebastian Ott Committed by Heiko Carstens Aug 16, 2018

s390/pci: fix out of bounds access during irq setup



During interrupt setup we allocate interrupt vectors, walk the list of msi
descriptors, and fill in the message data. Requesting more interrupts than
supported on s390 can lead to an out of bounds access.

When we restrict the number of interrupts we should also stop walking the
msi list after all supported interrupts are handled.

Cc: stable@vger.kernel.org
Signed-off-by: Sebastian Ott <sebott@linux.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>

parent 2395103b

arch/s390/pci/pci.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -421,6 +421,8 @@ int arch_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type)
		hwirq = 0;
		for_each_pci_msi_entry(msi, pdev) {
		rc = -EIO;
		if (hwirq >= msi_vecs)
		break;
		irq = irq_alloc_desc(0); /* Alloc irq on node 0 */
		if (irq < 0)
		return -ENOMEM;

Admin message