Commit 8663890a authored Jun 06, 2013 by Aneesh Kumar K.V Committed by Benjamin Herrenschmidt Jun 20, 2013

mm/thp: use the correct function when updating access flags



We should use pmdp_set_access_flags to update access flags.  Archs like
powerpc use extra checks(_PAGE_BUSY) when updating a hugepage PTE.  A
set_pmd_at doesn't do those checks.  We should use set_pmd_at only when
updating a none hugepage PTE.

Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>a
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

parent 25e33ed9

mm/huge_memory.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1265,7 +1265,9 @@ struct page follow_trans_huge_pmd(struct vm_area_struct vma,
		* young bit, instead of the current set_pmd_at.
		*/
		_pmd = pmd_mkyoung(pmd_mkdirty(*pmd));
		set_pmd_at(mm, addr & HPAGE_PMD_MASK, pmd, _pmd);
		if (pmdp_set_access_flags(vma, addr & HPAGE_PMD_MASK,
		pmd, _pmd, 1))
		update_mmu_cache_pmd(vma, addr, pmd);
		}
		if ((flags & FOLL_MLOCK) && (vma->vm_flags & VM_LOCKED)) {
		if (page->mapping && trylock_page(page)) {

Admin message