Commit 864aa04c authored Sep 18, 2012 by Will Deacon

ARM: mm: use pteval_t to represent page protection values



When updating the page protection map after calculating the user_pgprot
value, the base protection map is temporarily stored in an unsigned long
type, causing truncation of the protection bits when LPAE is enabled.
This effectively means that calls to mprotect() will corrupt the upper
page attributes, clearing the XN bit unconditionally.

This patch uses pteval_t to store the intermediate protection values,
preserving the upper bits for 64-bit descriptors.

Cc: stable@vger.kernel.org
Acked-by: Nicolas Pitre <nico@linaro.org>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>

parent 3d70f8c6

arch/arm/mm/mmu.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -488,7 +488,7 @@ static void __init build_mem_type_table(void)
		#endif

		for (i = 0; i < 16; i++) {
		unsigned long v = pgprot_val(protection_map[i]);
		pteval_t v = pgprot_val(protection_map[i]);
		protection_map[i] = __pgprot(v \| user_pgprot);
		}

Admin message