Commit 86323850 authored Dec 06, 2017 by Eric Dumazet Committed by David S. Miller Dec 07, 2017

tcp: use current time in tcp_rcv_space_adjust()



When I switched rcv_rtt_est to high resolution timestamps, I forgot
that tp->tcp_mstamp needed to be refreshed in tcp_rcv_space_adjust()

Using an old timestamp leads to autotuning lags.

Fixes: 645f4c6f ("tcp: switch rcv_rtt_est and rcvq_space to high resolution timestamps")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Wei Wang <weiwan@google.com>
Cc: Neal Cardwell <ncardwell@google.com>
Cc: Yuchung Cheng <ycheng@google.com>
Acked-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6e237d09

net/ipv4/tcp_input.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -579,6 +579,7 @@ void tcp_rcv_space_adjust(struct sock *sk)
		int time;
		int copied;

		tcp_mstamp_refresh(tp);
		time = tcp_stamp_us_delta(tp->tcp_mstamp, tp->rcvq_space.time);
		if (time < (tp->rcv_rtt_est.rtt_us >> 3) \|\| tp->rcv_rtt_est.rtt_us == 0)
		return;

Admin message