Commit 8620546c authored Nov 11, 2014 by Johan Hovold Committed by David S. Miller Nov 12, 2014

net: phy: micrel: add led-mode sanity check



Make sure never to update more than two bits when setting the led mode,
something which could for example change the reference-clock setting.

Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 57a38eff

drivers/net/phy/micrel.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -173,6 +173,11 @@ static int kszphy_setup_led(struct phy_device *phydev,
		if (of_property_read_u32(of_node, "micrel,led-mode", &val))
		return 0;

		if (val > 3) {
		dev_err(&phydev->dev, "invalid led mode: 0x%02x\n", val);
		return -EINVAL;
		}

		temp = phy_read(phydev, reg);
		if (temp < 0)
		return temp;

Admin message