libata-sff: remove dead code (8612b4b4) · Commits · 戴 / test

Ever since v2.6.19 the code contains a check for CONFIG_NO_ATA_LEGACY. But that macro has never been defined. Apparently no one ran into problems on platforms that do not support compatibility mode. So remove this code that has been dead for over seven years. Signed-off-by:

Paul Bolle <pebolle@tiscali.nl> Signed-off-by:

Tejun Heo <tj@kernel.org>

drivers/ata/libata-sff.c

+0 −9

Original line number	Diff line number	Diff line
		@@ -2433,15 +2433,6 @@ int ata_pci_sff_activate_host(struct ata_host *host,
		mask = (1 << 2) \| (1 << 0);
		if ((tmp8 & mask) != mask)
		legacy_mode = 1;
		#if defined(CONFIG_NO_ATA_LEGACY)
		/* Some platforms with PCI limits cannot address compat
		port space. In that case we punt if their firmware has
		left a device in compatibility mode */
		if (legacy_mode) {
		printk(KERN_ERR "ata: Compatibility mode ATA is not supported on this platform, skipping.\n");
		return -EOPNOTSUPP;
		}
		#endif
		}

		if (!devres_open_group(dev, NULL, GFP_KERNEL))

Admin message