Commit 86126b77 authored Jun 25, 2018 by Florian Westphal Committed by Steffen Klassert Jun 25, 2018

xfrm: free skb if nlsk pointer is NULL



nlmsg_multicast() always frees the skb, so in case we cannot call
it we must do that ourselves.

Fixes: 21ee543e ("xfrm: fix race between netns cleanup and state expire notification")
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>

parent 8cc88773

net/xfrm/xfrm_user.c

+6 −4

Original line number	Diff line number	Diff line
		@@ -1025,10 +1025,12 @@ static inline int xfrm_nlmsg_multicast(struct net net, struct sk_buff skb,
		{
		struct sock *nlsk = rcu_dereference(net->xfrm.nlsk);

		if (nlsk)
		if (!nlsk) {
		kfree_skb(skb);
		return -EPIPE;
		}

		return nlmsg_multicast(nlsk, skb, pid, group, GFP_ATOMIC);
		else
		return -1;
		}

		static inline unsigned int xfrm_spdinfo_msgsize(void)

Admin message