Commit 85fe4025 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Al Viro
Browse files

fs: do not assign default i_ino in new_inode 



Instead of always assigning an increasing inode number in new_inode
move the call to assign it into those callers that actually need it.
For now callers that need it is estimated conservatively, that is
the call is added to all filesystems that do not assign an i_ino
by themselves.  For a few more filesystems we can avoid assigning
any inode number given that they aren't user visible, and for others
it could be done lazily when an inode number is actually needed,
but that's left for later patches.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarDave Chinner <dchinner@redhat.com>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent f991bd2e

drivers/infiniband/hw/ipath/ipath_fs.c

+1 −0
Original line number Diff line number Diff line
@@ -57,6 +57,7 @@ static int ipathfs_mknod(struct inode *dir, struct dentry *dentry, 
		goto bail;

	}



	inode->i_ino = get_next_ino();

	inode->i_mode = mode;

	inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME;

	inode->i_private = data;

drivers/infiniband/hw/qib/qib_fs.c

+1 −0
Original line number Diff line number Diff line
@@ -58,6 +58,7 @@ static int qibfs_mknod(struct inode *dir, struct dentry *dentry, 
		goto bail;

	}



	inode->i_ino = get_next_ino();

	inode->i_mode = mode;

	inode->i_uid = 0;

	inode->i_gid = 0;

drivers/misc/ibmasm/ibmasmfs.c

+1 −0
Original line number Diff line number Diff line
@@ -146,6 +146,7 @@ static struct inode *ibmasmfs_make_inode(struct super_block *sb, int mode) 
	struct inode *ret = new_inode(sb);



	if (ret) {

		ret->i_ino = get_next_ino();

		ret->i_mode = mode;

		ret->i_atime = ret->i_mtime = ret->i_ctime = CURRENT_TIME;

	}

drivers/oprofile/oprofilefs.c

+1 −0
Original line number Diff line number Diff line
@@ -28,6 +28,7 @@ static struct inode *oprofilefs_get_inode(struct super_block *sb, int mode) 
	struct inode *inode = new_inode(sb);



	if (inode) {

		inode->i_ino = get_next_ino();

		inode->i_mode = mode;

		inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME;

	}

drivers/usb/core/inode.c

+1 −0
Original line number Diff line number Diff line
@@ -276,6 +276,7 @@ static struct inode *usbfs_get_inode (struct super_block *sb, int mode, dev_t de 
	struct inode *inode = new_inode(sb);



	if (inode) {

		inode->i_ino = get_next_ino();

		inode->i_mode = mode;

		inode->i_uid = current_fsuid();

		inode->i_gid = current_fsgid();

CRA Git | Maintained and supported by SUSTech CRA and CCSE