Commit 85db06e5 authored Dec 10, 2008 by Marcelo Tosatti Committed by Avi Kivity Feb 15, 2009

KVM: mmu_notifiers release method



The destructor for huge pages uses the backing inode for adjusting
hugetlbfs accounting.

Hugepage mappings are destroyed by exit_mmap, after
mmu_notifier_release, so there are no notifications through
unmap_hugepage_range at this point.

The hugetlbfs inode can be freed with pages backed by it referenced
by the shadow. When the shadow releases its reference, the huge page
destructor will access a now freed inode.

Implement the release operation for kvm mmu notifiers to release page
refs before the hugetlbfs inode is gone.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: Avi Kivity <avi@redhat.com>

parent 7a0eb196

virt/kvm/kvm_main.c

+8 −0

Original line number	Diff line number	Diff line
		@@ -789,11 +789,19 @@ static int kvm_mmu_notifier_clear_flush_young(struct mmu_notifier *mn,
		return young;
		}

		static void kvm_mmu_notifier_release(struct mmu_notifier *mn,
		struct mm_struct *mm)
		{
		struct kvm *kvm = mmu_notifier_to_kvm(mn);
		kvm_arch_flush_shadow(kvm);
		}

		static const struct mmu_notifier_ops kvm_mmu_notifier_ops = {
		.invalidate_page = kvm_mmu_notifier_invalidate_page,
		.invalidate_range_start = kvm_mmu_notifier_invalidate_range_start,
		.invalidate_range_end = kvm_mmu_notifier_invalidate_range_end,
		.clear_flush_young = kvm_mmu_notifier_clear_flush_young,
		.release = kvm_mmu_notifier_release,
		};
		#endif /* CONFIG_MMU_NOTIFIER && KVM_ARCH_WANT_MMU_NOTIFIER */

Admin message