Commit 85d8ec20 authored Jan 17, 2020 by Jani Nikula

drm/i915/bios: check DDI port presence based on child device

Report port presence based on port presence in VBT alone, relaxing the
requirements on supported encoders (DP, DVI, or HDMI). The goal is to
make future changes easier, however there is a small risk of reporting
more ports present than before in case of dubious VBT.

Regarding the current callers of intel_bios_is_port_present(), the
potential issue might be caused by DVO_PORT_CRT being identified as port
E in dvo_port_to_port(). Hopefully no VBT has that on SKL+ which support
DP/DVI/HDMI on port E; the current CRT init code on HSW/BDW does not
care.

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/4338a29e4ed49e69f859dff1490fd85f6ae6177e.1579270868.git.jani.nikula@intel.com

parent c5faae5a

drivers/gpu/drm/i915/display/intel_bios.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -2236,9 +2236,7 @@ bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port por
		const struct ddi_vbt_port_info *port_info =
		&dev_priv->vbt.ddi_port_info[port];

		return port_info->supports_dp \|\|
		port_info->supports_dvi \|\|
		port_info->supports_hdmi;
		return port_info->child;
		}

		/* FIXME maybe deal with port A as well? */