Commit 85c95f20 authored Sep 10, 2018 by Mark Fasheh Committed by Al Viro Oct 17, 2018

vfs: dedupe should return EPERM if permission is not granted



Right now we return EINVAL if a process does not have permission to dedupe a
file. This was an oversight on my part. EPERM gives a true description of
the nature of our error, and EINVAL is already used for the case that the
filesystem does not support dedupe.

Signed-off-by: Mark Fasheh <mfasheh@suse.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Acked-by: David Sterba <dsterba@suse.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

parent 5de4480a

fs/read_write.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1991,7 +1991,7 @@ int vfs_dedupe_file_range_one(struct file *src_file, loff_t src_pos,
		if (ret < 0)
		goto out_drop_write;

		ret = -EINVAL;
		ret = -EPERM;
		if (!allow_file_dedupe(dst_file))
		goto out_drop_write;

Admin message