Commit 85b45ead authored Mar 21, 2019 by Himadri Pandya Committed by Greg Kroah-Hartman Mar 21, 2019

staging: netlogic: Remove unnecessary error print



Kmalloc normally produces a backtrace when there is not enough memory.
So it is unnecessary to print an error message that provides only this
information. Hence, remove pr_error() from memory allocation check.
Issue found using Coccinelle.

Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 4a278a92

drivers/staging/netlogic/xlr_net.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -386,10 +386,8 @@ static void xlr_config_spill(struct xlr_net_priv priv, int reg_start_0,
		base = priv->base_addr;
		spill_size = size;
		spill = kmalloc(spill_size + SMP_CACHE_BYTES, GFP_ATOMIC);
		if (!spill) {
		pr_err("Unable to allocate memory for spill area!\n");
		if (!spill)
		return ZERO_SIZE_PTR;
		}

		spill = PTR_ALIGN(spill, SMP_CACHE_BYTES);
		phys_addr = virt_to_phys(spill);

Admin message