Commit 85a6cd03 authored Mar 09, 2006 by Hugh Dickins Committed by Linus Torvalds Mar 09, 2006

[PATCH] page_add_file_rmap(): remove BUG_ON()s



Remove two early-development BUG_ONs from page_add_file_rmap.

The pfn_valid test (originally useful for checking that nobody passed an
artificial struct page) comes too late, since we already have the struct
page.

The PageAnon test (useful when anon was first distinguished from file rmap)
prevents ->nopage implementations from reusing ->mapping, which would
otherwise be available.

Signed-off-by: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 6218cf44

mm/rmap.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -537,9 +537,6 @@ void page_add_new_anon_rmap(struct page *page,
		*/
		void page_add_file_rmap(struct page *page)
		{
		BUG_ON(PageAnon(page));
		BUG_ON(!pfn_valid(page_to_pfn(page)));

		if (atomic_inc_and_test(&page->_mapcount))
		__inc_page_state(nr_mapped);
		}

Admin message