Commit 85a5745f authored Aug 26, 2020 by Krzysztof Kozlowski Committed by Thierry Reding Sep 24, 2020

pwm: bcm2835: Simplify with dev_err_probe()



Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>

parent f339e79b

drivers/pwm/pwm-bcm2835.c

+3 −7

Original line number	Diff line number	Diff line
		@@ -152,13 +152,9 @@ static int bcm2835_pwm_probe(struct platform_device *pdev)
		return PTR_ERR(pc->base);

		pc->clk = devm_clk_get(&pdev->dev, NULL);
		if (IS_ERR(pc->clk)) {
		ret = PTR_ERR(pc->clk);
		if (ret != -EPROBE_DEFER)
		dev_err(&pdev->dev, "clock not found: %d\n", ret);

		return ret;
		}
		if (IS_ERR(pc->clk))
		return dev_err_probe(&pdev->dev, PTR_ERR(pc->clk),
		"clock not found\n");

		ret = clk_prepare_enable(pc->clk);
		if (ret)

Admin message