mm/mempolicy.c: remove unnecessary is_valid_nodemask() (859f7ef1) · Commits · 戴 / test

When nodes is true, nsc->mask2 has already been filtered by nsc->mask1, which has already factored in node_states[N_MEMORY]. Signed-off-by:

Zhihui Zhang <zzhsuny@gmail.com> Cc: Mel Gorman <mel@csn.ul.ie> Cc: Oleg Nesterov <oleg@redhat.com> Signed-off-by:

mm/mempolicy.c

+2 −8

Original line number	Diff line number	Diff line
		@@ -162,12 +162,6 @@ static const struct mempolicy_operations {
		enum mpol_rebind_step step);
		} mpol_ops[MPOL_MAX];

		/* Check that the nodemask contains at least one populated zone */
		static int is_valid_nodemask(const nodemask_t *nodemask)
		{
		return nodes_intersects(*nodemask, node_states[N_MEMORY]);
		}

		static inline int mpol_store_user_nodemask(const struct mempolicy *pol)
		{
		return pol->flags & MPOL_MODE_FLAGS;
		@@ -202,7 +196,7 @@ static int mpol_new_preferred(struct mempolicy pol, const nodemask_t nodes)

		static int mpol_new_bind(struct mempolicy pol, const nodemask_t nodes)
		{
		if (!is_valid_nodemask(nodes))
		if (nodes_empty(*nodes))
		return -EINVAL;
		pol->v.nodes = *nodes;
		return 0;