Commit 859f57ca authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Alex Elder
Browse files

xfs: avoid synchronous transactions when deleting attr blocks 



Currently xfs_attr_inactive causes a synchronous transactions if we are
removing a file that has any extents allocated to the attribute fork, and
thus makes XFS extremely slow at removing files with out of line extended
attributes. The code looks a like a relict from the days before the busy
extent list, but with the busy extent list we avoid reusing data and attr
extents that have been freed but not commited yet, so this code is just
as superflous as the synchronous transactions for data blocks.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reported-by: default avatarBernd Schubert <bernd.schubert@itwm.fraunhofer.de>
Reviewed-by: default avatarDave Chinner <dchinner@redhat.com>
Signed-off-by: default avatarAlex Elder <aelder@sgi.com>
parent 4a06fd26

fs/xfs/xfs_attr.c

+0 −12
Original line number Diff line number Diff line
@@ -823,18 +823,6 @@ xfs_attr_inactive(xfs_inode_t *dp) 
	if (error)

		goto out;



	/*

	 * Signal synchronous inactive transactions unless this is a

	 * synchronous mount filesystem in which case we know that we're here

	 * because we've been called out of xfs_inactive which means that the

	 * last reference is gone and the unlink transaction has already hit

	 * the disk so async inactive transactions are safe.

	 */

	if (!(mp->m_flags & XFS_MOUNT_WSYNC)) {

		if (dp->i_d.di_anextents > 0)

			xfs_trans_set_sync(trans);

	}



	error = xfs_itruncate_extents(&trans, dp, XFS_ATTR_FORK, 0);

	if (error)

		goto out;

fs/xfs/xfs_bmap.c

+1 −9
Original line number Diff line number Diff line
@@ -3782,19 +3782,11 @@ xfs_bmap_compute_maxlevels( 
 * Routine to be called at transaction's end by xfs_bmapi, xfs_bunmapi

 * caller.  Frees all the extents that need freeing, which must be done

 * last due to locking considerations.  We never free any extents in

 * the first transaction.  This is to allow the caller to make the first

 * transaction a synchronous one so that the pointers to the data being

 * broken in this transaction will be permanent before the data is actually

 * freed.  This is necessary to prevent blocks from being reallocated

 * and written to before the free and reallocation are actually permanent.

 * We do not just make the first transaction synchronous here, because

 * there are more efficient ways to gain the same protection in some cases

 * (see the file truncation code).

 * the first transaction.

 *

 * Return 1 if the given transaction was committed and a new one

 * started, and 0 otherwise in the committed parameter.

 */

/*ARGSUSED*/

int						/* error */

xfs_bmap_finish(

	xfs_trans_t		**tp,		/* transaction pointer addr */

CRA Git | Maintained and supported by SUSTech CRA and CCSE