Commit 855fc73b authored Sep 25, 2006 by Al Viro Committed by Linus Torvalds Sep 24, 2006

[PATCH] wrong thing iounmapped (qla3xxx)



ql3xxx_probe() does ioremap and stores result in ->mem_map_registers.
On failure exit it does iounmap() of the same thing.

OTOH, ql3xxx_remove() does iounmap() of ->mmap_virt_base which is
 (a) never assigned and
 (b) never used other than in that iounmap() call.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent ee111d11

drivers/net/qla3xxx.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3508,7 +3508,7 @@ static void __devexit ql3xxx_remove(struct pci_dev *pdev)
		qdev->workqueue = NULL;
		}

		iounmap(qdev->mmap_virt_base);
		iounmap(qdev->mem_map_registers);
		pci_release_regions(pdev);
		pci_set_drvdata(pdev, NULL);
		free_netdev(ndev);

Admin message