Commit 855d9765 authored by Alexey Dobriyan's avatar Alexey Dobriyan Committed by Linus Torvalds
Browse files

proc: uninline proc_create() 

Save some code from ~320 invocations all clearing last argument.

	add/remove: 3/0 grow/shrink: 0/158 up/down: 45/-702 (-657)
	function                                     old     new   delta
	proc_create                                    -      17     +17
	__ksymtab_proc_create                          -      16     +16
	__kstrtab_proc_create                          -      12     +12
	yam_init_driver                              301     298      -3

		...

	cifs_proc_init                               249     228     -21
	via_fb_pci_probe                            2304    2280     -24

Link: http://lkml.kernel.org/r/20170819094702.GA27864@avx2


Signed-off-by: default avatarAlexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 1240ea0d

fs/proc/generic.c

+8 −0
Original line number Diff line number Diff line
@@ -499,6 +499,14 @@ out: 
}

EXPORT_SYMBOL(proc_create_data);

 

struct proc_dir_entry *proc_create(const char *name, umode_t mode,

				   struct proc_dir_entry *parent,

				   const struct file_operations *proc_fops)

{

	return proc_create_data(name, mode, parent, proc_fops, NULL);

}

EXPORT_SYMBOL(proc_create);



void proc_set_size(struct proc_dir_entry *de, loff_t size)

{

	de->size = size;

include/linux/proc_fs.h

+1 −7
Original line number Diff line number Diff line
@@ -28,13 +28,7 @@ extern struct proc_dir_entry *proc_create_data(const char *, umode_t, 
					       const struct file_operations *,

					       void *);



static inline struct proc_dir_entry *proc_create(

	const char *name, umode_t mode, struct proc_dir_entry *parent,

	const struct file_operations *proc_fops)

{

	return proc_create_data(name, mode, parent, proc_fops, NULL);

}



struct proc_dir_entry *proc_create(const char *name, umode_t mode, struct proc_dir_entry *parent, const struct file_operations *proc_fops);

extern void proc_set_size(struct proc_dir_entry *, loff_t);

extern void proc_set_user(struct proc_dir_entry *, kuid_t, kgid_t);

extern void *PDE_DATA(const struct inode *);

CRA Git | Maintained and supported by SUSTech CRA and CCSE