Commit 855a0fc3 authored Dec 17, 2013 by Frederic Weisbecker

nohz: Get timekeeping max deferment outside jiffies_lock

We don't need to fetch the timekeeping max deferment under the
jiffies_lock seqlock.

If the clocksource is updated concurrently while we stop the tick,
stop machine is called and the tick will be reevaluated again along with
uptodate jiffies and its related values.

Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Alex Shi <alex.shi@linaro.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: John Stultz <john.stultz@linaro.org>
Cc: Kevin Hilman <khilman@linaro.org>
Link: http://lkml.kernel.org/r/1387320692-28460-9-git-send-email-fweisbec@gmail.com

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>

parent 5acac1be

kernel/time/tick-sched.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -533,12 +533,13 @@ static ktime_t tick_nohz_stop_sched_tick(struct tick_sched *ts,
		struct clock_event_device *dev = __get_cpu_var(tick_cpu_device).evtdev;
		u64 time_delta;

		time_delta = timekeeping_max_deferment();

		/* Read jiffies and the time when jiffies were updated last */
		do {
		seq = read_seqbegin(&jiffies_lock);
		last_update = last_jiffies_update;
		last_jiffies = jiffies;
		time_delta = timekeeping_max_deferment();
		} while (read_seqretry(&jiffies_lock, seq));

		if (rcu_needs_cpu(cpu, &rcu_delta_jiffies) \|\|

Admin message