Commit 854e55ad authored Mar 15, 2018 by Josh Poimboeuf Committed by Arnaldo Carvalho de Melo Mar 19, 2018

objtool, perf: Fix GCC 8 -Wrestrict error



Starting with recent GCC 8 builds, objtool and perf fail to build with
the following error:

  ../str_error_r.c: In function ‘str_error_r’:
  ../str_error_r.c:25:3: error: passing argument 1 to restrict-qualified parameter aliases with argument 5 [-Werror=restrict]
     snprintf(buf, buflen, "INTERNAL ERROR: strerror_r(%d, %p, %zd)=%d", errnum, buf, buflen, err);

The code seems harmless, but there's probably no benefit in printing the
'buf' pointer in this situation anyway, so just remove it to make GCC
happy.

Reported-by: Laura Abbott <labbott@redhat.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Tested-by: Laura Abbott <labbott@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/20180316031154.juk2uncs7baffctp@treble


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent d0461794

tools/lib/str_error_r.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -22,6 +22,6 @@ char str_error_r(int errnum, char buf, size_t buflen)
		{
		int err = strerror_r(errnum, buf, buflen);
		if (err)
		snprintf(buf, buflen, "INTERNAL ERROR: strerror_r(%d, %p, %zd)=%d", errnum, buf, buflen, err);
		snprintf(buf, buflen, "INTERNAL ERROR: strerror_r(%d, [buf], %zd)=%d", errnum, buflen, err);
		return buf;
		}

Admin message