Unverified Commit 85288b3b authored by Mark Brown's avatar Mark Brown
Browse files

Merge series "ASoC: use inclusive language for bclk/fsync/topology" from... 

Merge series "ASoC: use inclusive language for bclk/fsync/topology" from Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>:

The SOF (Sound Open Firmware) tree contains a lot of references in
topology files to 'codec_slave'/'codec_master' terms, which in turn
come from alsa-lib and ALSA/ASoC topology support at the kernel
level. These terms are no longer compatible with the guidelines
adopted by the kernel community [1], standard organizations, and need
to change in backwards-compatible ways.

The main/secondary terms typically suggested in guidelines don't mean
anything for clocks, this patchset suggests instead the use of
'provider' and 'consumer' terms, with the 'codec' prefix kept to make
it clear that the codec is the reference. The CM/CS suffixes are also
replaced by CP/CC.

It can be argued that the change of suffix is invasive, but finding a
replacement that keeps the M and S shortcuts has proven difficult in
quite a few contexts.

The previous definitions are kept for backwards-compatibility so this
change should not have any functional impact. It is suggested that new
contributions only use the new terms but there is no requirement to
transition immediately to the new definitions for existing code. Intel
will however update all its past contributions related to bit
clock/frame sync configurations immediately.

This patchset contains the kernel changes only, the alsa-lib changes
were shared separately.

Feedback welcome
~Pierre

[1] https://lkml.org/lkml/2020/7/4/229

Pierre-Louis Bossart (4):
  ASoC: topology: use inclusive language for bclk and fsync
  ASoC: SOF: use inclusive language for bclk and fsync
  ASoC: Intel: atom: use inclusive language for SSP bclk/fsync
  ASoC: Intel: keembay: use inclusive language for bclk and fsync

 include/sound/soc-dai.h                  | 32 +++++++++++++++---------
 include/sound/sof/dai.h                  | 16 ++++++++----
 include/uapi/sound/asoc.h                | 22 ++++++++++------
 sound/soc/intel/atom/sst-atom-controls.c | 12 ++++-----
 sound/soc/intel/atom/sst-atom-controls.h |  4 +--
 sound/soc/intel/keembay/kmb_platform.c   | 22 ++++++++--------
 sound/soc/intel/keembay/kmb_platform.h   |  8 +++---
 sound/soc/soc-topology.c                 | 24 +++++++++---------
 sound/soc/sof/topology.c                 | 18 ++++++-------
 9 files changed, 89 insertions(+), 69 deletions(-)

--
2.25.1
parents 33ee67b4 a6e9717a

include/sound/soc-dai.h

+20 −12
Original line number Diff line number Diff line
@@ -72,21 +72,29 @@ struct snd_compr_stream; 
#define SND_SOC_DAIFMT_IB_IF		(4 << 8) /* invert BCLK + FRM */



/*

 * DAI hardware clock masters.

 * DAI hardware clock providers/consumers

 *

 * This is wrt the codec, the inverse is true for the interface

 * i.e. if the codec is clk and FRM master then the interface is

 * clk and frame secondary.

 * i.e. if the codec is clk and FRM provider then the interface is

 * clk and frame consumer.

 */

#define SND_SOC_DAIFMT_CBM_CFM		(1 << 12) /* codec clk & FRM master */

#define SND_SOC_DAIFMT_CBS_CFM		(2 << 12) /* codec clk secondary & FRM master */

#define SND_SOC_DAIFMT_CBM_CFS		(3 << 12) /* codec clk master & frame secondary */

#define SND_SOC_DAIFMT_CBS_CFS		(4 << 12) /* codec clk & FRM secondary */

#define SND_SOC_DAIFMT_CBP_CFP		(1 << 12) /* codec clk provider & frame provider */

#define SND_SOC_DAIFMT_CBC_CFP		(2 << 12) /* codec clk consumer & frame provider */

#define SND_SOC_DAIFMT_CBP_CFC		(3 << 12) /* codec clk provider & frame consumer */

#define SND_SOC_DAIFMT_CBC_CFC		(4 << 12) /* codec clk consumer & frame follower */



/* previous definitions kept for backwards-compatibility, do not use in new contributions */

#define SND_SOC_DAIFMT_CBM_CFM		SND_SOC_DAIFMT_CBP_CFP

#define SND_SOC_DAIFMT_CBS_CFM		SND_SOC_DAIFMT_CBC_CFP

#define SND_SOC_DAIFMT_CBM_CFS		SND_SOC_DAIFMT_CBP_CFC

#define SND_SOC_DAIFMT_CBS_CFS		SND_SOC_DAIFMT_CBC_CFC



#define SND_SOC_DAIFMT_FORMAT_MASK		0x000f

#define SND_SOC_DAIFMT_CLOCK_MASK		0x00f0

#define SND_SOC_DAIFMT_INV_MASK			0x0f00

#define SND_SOC_DAIFMT_MASTER_MASK	0xf000

#define SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK	0xf000



#define SND_SOC_DAIFMT_MASTER_MASK	SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK



/*

 * Master Clock Directions

include/sound/sof/dai.h

+11 −5
Original line number Diff line number Diff line
@@ -34,15 +34,21 @@ 
#define SOF_DAI_FMT_IB_NF	(3 << 8) /**< invert BCLK + nor FRM */

#define SOF_DAI_FMT_IB_IF	(4 << 8) /**< invert BCLK + FRM */



#define SOF_DAI_FMT_CBM_CFM	(0 << 12) /**< codec clk & FRM master */

#define SOF_DAI_FMT_CBS_CFM	(2 << 12) /**< codec clk slave & FRM master */

#define SOF_DAI_FMT_CBM_CFS	(3 << 12) /**< codec clk master & frame slave */

#define SOF_DAI_FMT_CBS_CFS	(4 << 12) /**< codec clk & FRM slave */

#define SOF_DAI_FMT_CBP_CFP	(0 << 12) /**< codec bclk provider & frame provider */

#define SOF_DAI_FMT_CBC_CFP	(2 << 12) /**< codec bclk consumer & frame provider */

#define SOF_DAI_FMT_CBP_CFC	(3 << 12) /**< codec bclk provider & frame consumer */

#define SOF_DAI_FMT_CBC_CFC	(4 << 12) /**< codec bclk consumer & frame consumer */



/* keep old definitions for backwards compatibility */

#define SOF_DAI_FMT_CBM_CFM	SOF_DAI_FMT_CBP_CFP

#define SOF_DAI_FMT_CBS_CFM	SOF_DAI_FMT_CBC_CFP

#define SOF_DAI_FMT_CBM_CFS	SOF_DAI_FMT_CBP_CFC

#define SOF_DAI_FMT_CBS_CFS	SOF_DAI_FMT_CBC_CFC



#define SOF_DAI_FMT_FORMAT_MASK		0x000f

#define SOF_DAI_FMT_CLOCK_MASK		0x00f0

#define SOF_DAI_FMT_INV_MASK		0x0f00

#define SOF_DAI_FMT_MASTER_MASK		0xf000

#define SOF_DAI_FMT_CLOCK_PROVIDER_MASK	0xf000



/** \brief Types of DAI */

enum sof_ipc_dai_type {

include/uapi/sound/asoc.h

+14 −8
Original line number Diff line number Diff line
@@ -170,16 +170,22 @@ 
#define SND_SOC_TPLG_LNK_FLGBIT_VOICE_WAKEUP            (1 << 3)



/* DAI topology BCLK parameter

 * For the backwards capability, by default codec is bclk master

 * For the backwards capability, by default codec is bclk provider

 */

#define SND_SOC_TPLG_BCLK_CM         0 /* codec is bclk master */

#define SND_SOC_TPLG_BCLK_CS         1 /* codec is bclk slave */

#define SND_SOC_TPLG_BCLK_CP         0 /* codec is bclk provider */

#define SND_SOC_TPLG_BCLK_CC         1 /* codec is bclk consumer */

/* keep previous definitions for compatibility */

#define SND_SOC_TPLG_BCLK_CM         SND_SOC_TPLG_BCLK_CP

#define SND_SOC_TPLG_BCLK_CS         SND_SOC_TPLG_BCLK_CC



/* DAI topology FSYNC parameter

 * For the backwards capability, by default codec is fsync master

 * For the backwards capability, by default codec is fsync provider

 */

#define SND_SOC_TPLG_FSYNC_CM         0 /* codec is fsync master */

#define SND_SOC_TPLG_FSYNC_CS         1 /* codec is fsync slave */

#define SND_SOC_TPLG_FSYNC_CP         0 /* codec is fsync provider */

#define SND_SOC_TPLG_FSYNC_CC         1 /* codec is fsync consumer */

/* keep previous definitions for compatibility */

#define SND_SOC_TPLG_FSYNC_CM         SND_SOC_TPLG_FSYNC_CP

#define SND_SOC_TPLG_FSYNC_CS         SND_SOC_TPLG_FSYNC_CC



/*

 * Block Header.
@@ -336,8 +342,8 @@ struct snd_soc_tplg_hw_config { 
	__u8 clock_gated;	/* SND_SOC_TPLG_DAI_CLK_GATE_ value */

	__u8 invert_bclk;	/* 1 for inverted BCLK, 0 for normal */

	__u8 invert_fsync;	/* 1 for inverted frame clock, 0 for normal */

	__u8 bclk_master;	/* SND_SOC_TPLG_BCLK_ value */

	__u8 fsync_master;	/* SND_SOC_TPLG_FSYNC_ value */

	__u8 bclk_provider;	/* SND_SOC_TPLG_BCLK_ value */

	__u8 fsync_provider;	/* SND_SOC_TPLG_FSYNC_ value */

	__u8 mclk_direction;    /* SND_SOC_TPLG_MCLK_ value */

	__le16 reserved;	/* for 32bit alignment */

	__le32 mclk_rate;	/* MCLK or SYSCLK freqency in Hz */

sound/soc/intel/atom/sst-atom-controls.c

+6 −6
Original line number Diff line number Diff line
@@ -827,14 +827,14 @@ static int sst_get_ssp_mode(struct snd_soc_dai *dai, unsigned int fmt) 
{

	int format;



	format = (fmt & SND_SOC_DAIFMT_MASTER_MASK);

	format = (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK);

	dev_dbg(dai->dev, "Enter:%s, format=%x\n", __func__, format);



	switch (format) {

	case SND_SOC_DAIFMT_CBS_CFS:

		return SSP_MODE_MASTER;

	case SND_SOC_DAIFMT_CBM_CFM:

		return SSP_MODE_SLAVE;

	case SND_SOC_DAIFMT_CBC_CFC:

		return SSP_MODE_PROVIDER;

	case SND_SOC_DAIFMT_CBP_CFP:

		return SSP_MODE_CONSUMER;

	default:

		dev_err(dai->dev, "Invalid ssp protocol: %d\n", format);

	}
@@ -905,7 +905,7 @@ static const struct sst_ssp_config sst_ssp_configs = { 
	.ssp_id = SSP_CODEC,

	.bits_per_slot = 24,

	.slots = 4,

	.ssp_mode = SSP_MODE_MASTER,

	.ssp_mode = SSP_MODE_PROVIDER,

	.pcm_mode = SSP_PCM_MODE_NETWORK,

	.duplex = SSP_DUPLEX,

	.ssp_protocol = SSP_MODE_PCM,

sound/soc/intel/atom/sst-atom-controls.h

+2 −2
Original line number Diff line number Diff line
@@ -439,8 +439,8 @@ struct sst_cmd_tone_stop { 
} __packed;



enum sst_ssp_mode {

	SSP_MODE_MASTER = 0,

	SSP_MODE_SLAVE = 1,

	SSP_MODE_PROVIDER = 0,

	SSP_MODE_CONSUMER = 1,

};



enum sst_ssp_pcm_mode {

CRA Git | Maintained and supported by SUSTech CRA and CCSE