perf test sdt: Handle realpath() failure (8526bafc) · Commits · 戴 / test

It can return NULL, in which case we should bail out and remove the directory created with mkdtemp(), which is stored in the "__tempdir" variable, not in "tempdir". Cc: Masami Hiramatsu <mhiramat@kernel.org> Fixes: ("perf test: Add a test case for SDT event") Signed-off-by:

Arnaldo Carvalho de Melo <acme@redhat.com>

tools/perf/tests/sdt.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -83,6 +83,8 @@ int test__sdt_event(int subtests __maybe_unused)
		}
		/* Note that buildid_dir must be an absolute path */
		tempdir = realpath(__tempdir, NULL);
		if (tempdir == NULL)
		goto error_rmdir;

		/* At first, scan itself */
		set_buildid_dir(tempdir);
		@@ -100,7 +102,7 @@ int test__sdt_event(int subtests __maybe_unused)

		error_rmdir:
		/* Cleanup temporary buildid dir */
		rm_rf(tempdir);
		rm_rf(__tempdir);
		error:
		free(tempdir);
		free(myself);

Admin message