Commit 8521fc50 authored Jul 26, 2011 by Michal Hocko Committed by Linus Torvalds Jul 26, 2011

memcg: get rid of percpu_charge_mutex lock



percpu_charge_mutex protects from multiple simultaneous per-cpu charge
caches draining because we might end up having too many work items.  At
least this was the case until commit 26fe6168 ("memcg: fix percpu
cached charge draining frequency") when we introduced a more targeted
draining for async mode.

Now that also sync draining is targeted we can safely remove mutex
because we will not send more work than the current number of CPUs.
FLUSHING_CACHED_CHARGE protects from sending the same work multiple
times and stock->nr_pages == 0 protects from pointless sending a work if
there is obviously nothing to be done.  This is of course racy but we
can live with it as the race window is really small (we would have to
see FLUSHING_CACHED_CHARGE cleared while nr_pages would be still
non-zero).

The only remaining place where we can race is synchronous mode when we
rely on FLUSHING_CACHED_CHARGE test which might have been set by other
drainer on the same group but we should wait in that case as well.

Signed-off-by: Michal Hocko <mhocko@suse.cz>
Cc: Balbir Singh <bsingharora@gmail.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 3e92041d

mm/memcontrol.c

+2 −10

Original line number	Diff line number	Diff line
		@@ -2092,7 +2092,6 @@ struct memcg_stock_pcp {
		#define FLUSHING_CACHED_CHARGE (0)
		};
		static DEFINE_PER_CPU(struct memcg_stock_pcp, memcg_stock);
		static DEFINE_MUTEX(percpu_charge_mutex);

		/*
		* Try to consume stocked charge on this cpu. If success, one page is consumed
		@@ -2199,7 +2198,8 @@ static void drain_all_stock(struct mem_cgroup *root_mem, bool sync)

		for_each_online_cpu(cpu) {
		struct memcg_stock_pcp *stock = &per_cpu(memcg_stock, cpu);
		if (test_bit(FLUSHING_CACHED_CHARGE, &stock->flags))
		if (mem_cgroup_same_or_subtree(root_mem, stock->cached) &&
		test_bit(FLUSHING_CACHED_CHARGE, &stock->flags))
		flush_work(&stock->work);
		}
		out:
		@@ -2214,22 +2214,14 @@ out:
		*/
		static void drain_all_stock_async(struct mem_cgroup *root_mem)
		{
		/*
		* If someone calls draining, avoid adding more kworker runs.
		*/
		if (!mutex_trylock(&percpu_charge_mutex))
		return;
		drain_all_stock(root_mem, false);
		mutex_unlock(&percpu_charge_mutex);
		}

		/* This is a synchronous drain interface. */
		static void drain_all_stock_sync(struct mem_cgroup *root_mem)
		{
		/* called when force_empty is called */
		mutex_lock(&percpu_charge_mutex);
		drain_all_stock(root_mem, true);
		mutex_unlock(&percpu_charge_mutex);
		}

		/*

Admin message