i2c: i801: fix DNV's SMBCTRL register offset (851a1511) · Commits · 戴 / test

DNV's iTCO is slightly different with SMBCTRL sitting at a different offset when compared to all other devices. Let's fix so that we can properly use iTCO watchdog. Fixes: ("i2c: i801: Add support for Intel DNV") Cc: <stable@vger.kernel.org> # v4.4+ Signed-off-by:

Felipe Balbi <felipe.balbi@linux.intel.com> Reviewed-by:

Jean Delvare <jdelvare@suse.de> Signed-off-by:

Wolfram Sang <wsa@the-dreams.de>

drivers/i2c/busses/i2c-i801.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -140,6 +140,7 @@

		#define SBREG_BAR 0x10
		#define SBREG_SMBCTRL 0xc6000c
		#define SBREG_SMBCTRL_DNV 0xcf000c

		/* Host status bits for SMBPCISTS */
		#define SMBPCISTS_INTS BIT(3)
		@@ -1399,7 +1400,11 @@ static void i801_add_tco(struct i801_priv *priv)
		spin_unlock(&p2sb_spinlock);

		res = &tco_res[ICH_RES_MEM_OFF];
		if (pci_dev->device == PCI_DEVICE_ID_INTEL_DNV_SMBUS)
		res->start = (resource_size_t)base64_addr + SBREG_SMBCTRL_DNV;
		else
		res->start = (resource_size_t)base64_addr + SBREG_SMBCTRL;

		res->end = res->start + 3;
		res->flags = IORESOURCE_MEM;

Admin message