Commit 84fb144b authored Feb 04, 2008 by H. Peter Anvin Committed by Ingo Molnar Feb 04, 2008

x86: reintroduce volatile keyword in prototype to clflush()



The volatile keyword was removed from the clflush() prototype
in commit e34907ae; the comment there
states:

    x86: remove volatile keyword from clflush.

    the p parameter is an explicit memory reference, and is
    enough to prevent gcc to being nasty here. The volatile
    seems completely not needed.

This reflects incorrect understanding of the function of the volatile
keyword there.  The purpose of the volatile keyword is informing gcc
that it is safe to pass a volatile pointer to this function.

Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

parent 2b06ac86

include/asm-x86/system.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -271,9 +271,9 @@ static inline void native_wbinvd(void)

		#endif /* __KERNEL__ */

		static inline void clflush(void *__p)
		static inline void clflush(volatile void *__p)
		{
		asm volatile("clflush %0" : "+m" ((char __force )__p));
		asm volatile("clflush %0" : "+m" ((volatile char __force )__p));
		}

		#define nop() __asm__ __volatile__ ("nop")

Admin message